Implemented stacks and queues in Java #897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikac
reviewed
Oct 23, 2021
| /* | ||
| * 'peek' returns the first element of the queue without removing it | ||
| */ | ||
| T peek(); |
There was a problem hiding this comment.
This is really just a detail thing but the chapter uses top and front for stack and queue. Maybe change peek to front for queue and top for stack?
|
[lang: java] |
Amaras
added
the
Implementation
|
I don't have anything more to add to @henrikac's review, so I'll wait for you to commit changes, and I'll review it then. |
henrikac
approved these changes
Oct 23, 2021
leios
added a commit
that referenced
this pull request
Oct 25, 2021
* pep8ify python * rename Tree_example.py * standardize python output * standardize c output * standardize c++ output * standardize rust output * standardize javascript output * standardize julia output * Standardized Coconut output * fix coconut * standardize go output * standardize common lisp output * Verlet Integration: Output standardization (#855) * Standardize julia output * Standardize kotlin output This also fixes a previous bug, which caused the time and velocity values to not get printed correctly. * Standardized c output * Standardized cpp output * Standardized lisp output * Standardized fortran output I was not able to prevent the preceding whitespaces, but they can just be trimmed. * Standardized go output * Standardized java output * Standardize javascript output * Standardize nim output * Standardize python output * Standardize ruby output As the original implementation only returned the time and not the velocity, the code needed to be adjusted a bit. Now it returns the two values as an array which gets deconstructed and printed. * Standardize rust output * Standardize swift output * Standardized haskell output * Standardized haskell output (no quote marks) * attempt at fix for asm Co-authored-by: Jérémie Gillet <[email protected]> Co-authored-by: James Schloss <[email protected]> * standardize php output * standardize swift output * removed outdated comments in Coconut implementation * standardize haskell output * Fix asm exit codes (#858) * standardize crystal output * Flood fill in Coconut (#836) * Added Barnsley fern in Coconut (+ .editorconfig for Coconut) (#814) * Added the Jarvis march in Coconut (#734) * Fix minor typo * Change folder structure of convolutions (#861) This puts every chapters' code into its own directory, which is useful for automatic validation. * standardize csharp output * standardize java output * fix php line numbers and python filename * fix coconut and python line numbers * fix minor bug in C * fix labels and minor bug in go * minor label fix in python * Huffman encoding in Coconut (#732) * Update README.md Changing readme link to reflect change in twitch url * Add C# implemenation for 1D Convolutions (#846) * Add C# implemenation for 1D Convolutions * Fix off by one error and julia line numbers * Fix off by one error for linear convolutions * Fix trailing zero * Update contents/convolutions/code/csharp/1DConvolution.cs Co-authored-by: Trashtalk217 <[email protected]> * Update contents/convolutions/code/csharp/1DConvolution.cs Co-authored-by: Trashtalk217 <[email protected]> * Update contents/convolutions/code/csharp/1DConvolution.cs Co-authored-by: Trashtalk217 <[email protected]> * Update contents/convolutions/code/csharp/1DConvolution.cs Co-authored-by: Trashtalk217 <[email protected]> * Update contents/convolutions/code/csharp/1DConvolution.cs Co-authored-by: Trashtalk217 <[email protected]> * Update contents/convolutions/code/csharp/1DConvolution.cs Co-authored-by: Trashtalk217 <[email protected]> * Update contents/convolutions/code/csharp/1DConvolution.cs Co-authored-by: Trashtalk217 <[email protected]> * Update contents/convolutions/code/csharp/1DConvolution.cs Co-authored-by: Trashtalk217 <[email protected]> * Update contents/convolutions/code/csharp/1DConvolution.cs Co-authored-by: Trashtalk217 <[email protected]> * Update contents/convolutions/code/csharp/1DConvolution.cs Co-authored-by: Trashtalk217 <[email protected]> * Update contents/convolutions/code/csharp/1DConvolution.cs Co-authored-by: Trashtalk217 <[email protected]> * Update contents/convolutions/code/csharp/1DConvolution.cs Co-authored-by: Trashtalk217 <[email protected]> * Update contents/convolutions/code/csharp/1DConvolution.cs Co-authored-by: Trashtalk217 <[email protected]> * Add trailing new line Co-authored-by: Trashtalk217 <[email protected]> * IFS Common Lisp implementation (#722) * first working version * cleaned up the chaos-game function and added some helpfull comments * changed the .md file and upped iterations * Skeleton of the final solution * Update contents/IFS/IFS.md Co-authored-by: Eric Berquist <[email protected]> Co-authored-by: James Schloss <[email protected]> Co-authored-by: Eric Berquist <[email protected]> * added MonteCarlo in PowerShell (#760) * Add Rust implementation for The Barnsley Fern (#818) * Add Rust implementation for The Barnsley Fern * Change operators constants and add Cargo.toml * Fix bug in matrix multiplication Co-authored-by: James Schloss <[email protected]> * changing barnsley.md to read the correct coconut file (#867) * added approximate counting implementation in python (#866) * added approximate counting implementation in python * Update approximate_counting.py * updating approximate_counting.py * removed redundancies * fixing linking issues in convolution chapter (#868) * Add initial devcontainer (#862) * small changes to convolutional theorem chapter and code to make things more reproduceable (#872) * added convolutional theorem implementation in python (#869) * added convolutional theorem implementation in python * fixed chapter linking * added comments to the code * changed random distribution to sawtooth * corrected previous commit * fixed comments Co-authored-by: James Schloss <[email protected]> * Use `[#]\n` instead of `[#]` for human readable output (#873) * Add approximate counting algorithm in C (#844) * Add approximate counting algorithm in C * Fix typo Co-authored-by: stormofice <[email protected]> Co-authored-by: stormofice <[email protected]> Co-authored-by: James Schloss <[email protected]> * added 1d convolution implementation in python (#874) * added 1d convolution implementation in python * fixed some mistakes in the code so it outputs correct results * making the code look better * spacing code properly for readability * fixing 1d convolution markdown file (#879) * Add racket setup to devcontainer (#875) * Normalize inputs for scheme euclid algorithm (#878) Change inputs to make it consistent with other examples. * Add initial setup for Swift in devcontainer (#880) * Add scheme setup to devcontainer (#876) * Clean up Monte Carlo integration in Racket (#781) * Clean up Monte Carlo integration in Racket * Add blank lines in Monte Carlo integration in Clojure * Change Racket lang include from lisp to racket * Add C++ code for Flood Fill algorithm (#860) * fixing chapter to use split-op code (#888) * use [#]\n for readability * Implemented stacks and queues in Java (#897) * Java tree traversal: updated dfsRecursiveInOrderBinary (#899) * Tree traversal in smalltalk (#453) * fixed print statements (#901) * Fixes in PATH that make dlang, emojicode and factor usable (#890) * fixing huffman encoding for Julia and adding Test (#828) * JavaScript tree traversal: updated dfsInorder (#902) * julia: change printf to print * pep8ify python * rename Tree_example.py * standardize python output * standardize c output * standardize c++ output * standardize rust output * standardize javascript output Resolved conflict with master (by Amaras) * standardize julia output Resolved conflict with master (by Amaras) * Standardized Coconut output * fix coconut * standardize go output * standardize common lisp output * standardize php output * standardize swift output * removed outdated comments in Coconut implementation * standardize haskell output * standardize crystal output * standardize csharp output * standardize java output Resolved the conflict with fixing dfs * fix php line numbers and python filename * fix coconut and python line numbers * fix minor bug in C * fix labels and minor bug in go * minor label fix in python * use [#]\n for readability * julia: change printf to print * update Tree.java. remove MainClass.java Co-authored-by: Sammy Plat <[email protected]> Co-authored-by: stormofice <[email protected]> Co-authored-by: Jérémie Gillet <[email protected]> Co-authored-by: James Schloss <[email protected]> Co-authored-by: Eric Berquist <[email protected]> Co-authored-by: Trashtalk217 <[email protected]> Co-authored-by: PaddyKe <[email protected]> Co-authored-by: Dimitri Belopopsky <[email protected]> Co-authored-by: Ayman Lafaz <[email protected]> Co-authored-by: Nicholas Tindle <[email protected]> Co-authored-by: Mahdi <[email protected]> Co-authored-by: Henrik Christensen <[email protected]> Co-authored-by: Neverik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.